Skip to content

[release-0.5] Backport #19022 #21708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented May 5, 2017

This backports some fixes for ARMv7 support. It makes it easier for Julia to autodetect the proper version, and fixes the binaries so that they can run on ARM processors that don't have NEON support. If I download the beta 0.5.2 binary (6accda38c4) from this thread and try to run it on a scaleway server with no NEON support, it SIGILL's. With this change, we can compile with JULIA_CPU_TYPE=generic (which is what the buildbots are doing anyway) and it works okay.

@tkelman tkelman changed the base branch from release-0.5 to tk/backports-0.5.2 May 5, 2017 08:50
@tkelman
Copy link
Contributor

tkelman commented May 5, 2017

last time around this caused build issues which is why I was leaving this alone on release-0.5

@tkelman
Copy link
Contributor

tkelman commented May 5, 2017

please cherry-pick with -x -e and add cross references to the PR to the commit message. would also be slightly cleaner if this branch were rebased against the 0.5.1 tag instead of the tip of release-0.5

@staticfloat
Copy link
Member Author

staticfloat commented May 5, 2017

last time around this caused build issues which is why I was leaving this alone on release-0.5

I'm not sure exactly what build issues you're referring to, but I think it's worth the effort so that we can support non-NEON ARM architectures.

I've redone my cherry-picking, thanks for the pointers.

@tkelman
Copy link
Contributor

tkelman commented May 5, 2017

still missing a reference to the pr # in the commit messages

@staticfloat staticfloat force-pushed the sf/backport_19022 branch from b4498fa to cab5345 Compare May 5, 2017 17:13
@staticfloat
Copy link
Member Author

Sorry, missed that. Done.

@tkelman
Copy link
Contributor

tkelman commented May 5, 2017

those commit shas also don't make much sense, those aren't linking to the commit that's on master

yuyichao and others added 3 commits May 5, 2017 10:35
* Allow `cpu_target` to specify a generic arch, matching the behavior on x86
* Detect the CPU arch version with `uname`
* Require `armv6`

    Close #13270 (`armv5` is not supported)
    Fix #18042

* Remove warning about generic arch since it's not really useful

    Fix #17549

* Require at least the same ARM arch version and profile the C code is compiled with

(cherry picked from commit 760bc41 and PR #18100)
(cherry picked from commit 5977167 and PR #18100)
Explicitly disable NEON when a generic arch is specified

(cherry picked from commit a90db99 and PR #19022)
@staticfloat staticfloat force-pushed the sf/backport_19022 branch from cab5345 to ea99033 Compare May 5, 2017 17:36
@staticfloat
Copy link
Member Author

Rarely have I been so confused by a git mess. One more try.

@tkelman tkelman changed the base branch from tk/backports-0.5.2 to release-0.5 May 6, 2017 15:46
@staticfloat
Copy link
Member Author

Closing this as 0.6.0 is out now.

@ViralBShah ViralBShah deleted the sf/backport_19022 branch October 22, 2017 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants